fix(keyboard): Change keyboard style during setStyle #1920
Conversation
theproducer
requested review from
markemer,
jcesarmobile,
ItsChaceD,
IT-MikeS and
giralte-ionic
|
Released dev build of keyboard with dev version: 6.0.0-dev-1920-20231130T153844.0 |
There was a problem hiding this comment.
This doesn't fix the reported issue.
The reported issue is when the keyboard is hidden, if you change the style, next time the keyboard appears it still has the old style on iOS 17 devices, and on the second time it appears it has the correct style.
So calling [self changeKeyboardStyle:self.keyboardStyle]; on onKeyboardWillHide will have no effect since the keyboard is hidden and onKeyboardWillHide will not be called.
What seems to work is to call [self changeKeyboardStyle:self.keyboardStyle]; inside the - (void)setStyle:(CAPPluginCall *)call.
Ah right, sorry, I was tunnel visioned in to testing toggling open keyboards back and forth. |
theproducer
changed the title
There was a problem hiding this comment.
This other call to the same method can be removed now
https://github.com/ionic-team/capacitor-plugins/blob/main/keyboard/ios/Sources/KeyboardPlugin/Keyboard.m#L124
Fixes an issue on iOS 17 where setting keyboard style would not apply the new appearance.
closes: #1905