Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push Notifications #126

Merged
merged 41 commits into from
Jan 11, 2021
Merged

Push Notifications #126

merged 41 commits into from
Jan 11, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Dec 5, 2020 •
edited
Loading

@imhoffd imhoffd mentioned this pull request Dec 5, 2020
Closed
imhoffd
imhoffd commented Dec 30, 2020
View reviewed changes
push-notifications/android/build.gradle Outdated Show resolved Hide resolved
push-notifications/android/build.gradle Outdated Show resolved Hide resolved
push-notifications/android/build.gradle Outdated Show resolved Hide resolved
push-notifications/ios/Plugin/PushNotifications.swift Outdated Show resolved Hide resolved
push-notifications/ios/Plugin/PushNotificationsPlugin.swift Outdated Show resolved Hide resolved
push-notifications/ios/Plugin/PushNotificationsPlugin.swift Outdated Show resolved Hide resolved
push-notifications/package.json Outdated Show resolved Hide resolved
push-notifications/package.json Show resolved Hide resolved
imhoffd
imhoffd commented Jan 8, 2021
View reviewed changes
Copy link
Contributor Author

@imhoffd imhoffd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to switch from Color.parseColor() to WebColor.parseColor() (see #140 and ionic-team/capacitor#3947)

The docs for lightColor will also need to be updated

@theproducer
Migrate from Color.parseColor() to WebColor.parseColor()
b8a67e9
@theproducer
Merge branch 'push-notifications' of github.com:ionic-team/capacitor-…
3e81a14 
…plugins into push-notifications

# Conflicts:
#	push-notifications/README.md
#	push-notifications/src/definitions.ts
@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 8, 2021

LGTM 💙

@imhoffd imhoffd merged commit 0bcd833 into main Jan 11, 2021
@imhoffd imhoffd deleted the push-notifications branch January 11, 2021 23:02
@thomasvidas thomasvidas mentioned this pull request Jan 12, 2021
Closed
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Jan 20, 2023
@imhoffd @theproducer
feat: Push Notifications plugin (ionic-team#126)
7c9eeae 
Co-authored-by: Joseph Pender <joey@ionic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith approved these changes

@theproducer theproducer theproducer approved these changes

@carlpoole carlpoole carlpoole approved these changes

Assignees

@theproducer theproducer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imhoffd @ikeith @theproducer @carlpoole