fix(splash): Make splash launch delay timeout zero to speed up capaci…

…tor boot
ionic-team · May 5, 2020 · b29346b · b29346b
1 parent 21c320c
commit b29346b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/Splash.java b/android/capacitor/src/main/java/com/getcapacitor/Splash.java
@@ -28,7 +28,7 @@ public interface SplashListener {
 
   public static final String CONFIG_KEY_PREFIX = "plugins.SplashScreen.";
 
-  public static final int DEFAULT_LAUNCH_SHOW_DURATION = 3000;
+  public static final int DEFAULT_LAUNCH_SHOW_DURATION = 0;
   public static final int DEFAULT_FADE_IN_DURATION = 200;
   public static final int DEFAULT_FADE_OUT_DURATION = 200;
   public static final int DEFAULT_SHOW_DURATION = 3000;
@@ -168,6 +168,11 @@ private static void buildViews(Context c) {
   public static void showOnLaunch(final BridgeActivity a) {
     Integer duration = Config.getInt(CONFIG_KEY_PREFIX + "launchShowDuration", DEFAULT_LAUNCH_SHOW_DURATION);
     Boolean autohide = Config.getBoolean(CONFIG_KEY_PREFIX + "launchAutoHide", DEFAULT_AUTO_HIDE);
+
+    if (duration == 0) {
+      return;
+    }
+
     show(a, duration, 0, DEFAULT_FADE_OUT_DURATION, autohide, null, true);
   }
 

diff --git a/ios/Capacitor/Capacitor/Plugins/SplashScreen.swift b/ios/Capacitor/Capacitor/Plugins/SplashScreen.swift
@@ -11,7 +11,7 @@ public class CAPSplashScreenPlugin: CAPPlugin {
   var hideTask: Any?
   var isVisible: Bool = false
 
-  let launchShowDuration = 3000
+  let launchShowDuration = 0
   let launchAutoHide = true
 
   let defaultFadeInDuration = 200
@@ -115,6 +115,10 @@ public class CAPSplashScreenPlugin: CAPPlugin {
     let launchSpinnerStyleConfig = getConfigValue("iosSpinnerStyle") as? String ?? nil
     let launchSpinnerColorConfig = getConfigValue("spinnerColor") as? String ?? nil
 
+    if launchShowDurationConfig == 0 {
+      return
+    }
+
     let view = bridge.viewController.view
     view?.addSubview(imageView)