Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iOS Project. Replace public with open to make it easier to override the BrideViewController with custom code #2628

Closed
3 tasks
dungi opened this issue Mar 24, 2020 · 6 comments

Comments

@dungi
Copy link

dungi commented Mar 24, 2020

Feature Request

Describe the Feature Request

Need to replace "public" with "open" to make it easier to override the code in CAPBrideViewController

Platform Support Requested

  • Android
  • [x ] iOS
  • Electron
  • Web

Describe Preferred Solution

Need to replace "public" with "open" to make it easier to override the code in CAPBrideViewController

Describe Alternatives

Related Code

CAPBrideViewController.swift

@dungi
Copy link
Author

dungi commented Mar 25, 2020

Created a Pullrequest for that #2635

@jcesarmobile
Copy link
Member

why do you want/need to override CAPBrideViewController code?

@dungi
Copy link
Author

dungi commented Mar 26, 2020

Cause we want some own behaviour for some WebKit Things and add an Offline Screen and something like this.

@jcesarmobile
Copy link
Member

jcesarmobile commented Mar 31, 2020

We had a PR in the past and didn't merge because it wasn't needed for their use case
#1972

So if you want us to merge you have to provide more details about what you need, can you expand on those things?

@dungi
Copy link
Author

dungi commented Apr 1, 2020

The Problem with Extensions are, that you can't store stored properties. We want to handle some custom things for us, that would be more complex if we can't just inherit from the normal code base.

@dungi dungi closed this as completed Apr 21, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants