-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iOS Project. Replace public with open to make it easier to override the BrideViewController with custom code #2628
Comments
Created a Pullrequest for that #2635 |
why do you want/need to override CAPBrideViewController code? |
Cause we want some own behaviour for some WebKit Things and add an Offline Screen and something like this. |
We had a PR in the past and didn't merge because it wasn't needed for their use case So if you want us to merge you have to provide more details about what you need, can you expand on those things? |
The Problem with Extensions are, that you can't store stored properties. We want to handle some custom things for us, that would be more complex if we can't just inherit from the normal code base. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out. |
Feature Request
Describe the Feature Request
Need to replace "public" with "open" to make it easier to override the code in CAPBrideViewController
Platform Support Requested
Describe Preferred Solution
Need to replace "public" with "open" to make it easier to override the code in CAPBrideViewController
Describe Alternatives
Related Code
CAPBrideViewController.swift
The text was updated successfully, but these errors were encountered: