fix(checkbox): click events on ion-item now fire properly (#22561)

resolves #22557
ionic-team · Nov 24, 2020 · c45c8d5 · c45c8d5 · DavidWiesner · Nov 25, 2020
1 parent afcc46e
commit c45c8d5
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/core/src/components/checkbox/checkbox.tsx b/core/src/components/checkbox/checkbox.tsx
@@ -114,10 +114,7 @@ export class Checkbox implements ComponentInterface {
     }
   }
 
-  private onClick = (ev: Event) => {
-    ev.preventDefault();
-    ev.stopPropagation();
-
+  private onClick = () => {
     this.setFocus();
     this.checked = !this.checked;
     this.indeterminate = false;
@@ -171,6 +168,14 @@ export class Checkbox implements ComponentInterface {
           {labelText}
         </label>
         <input
+          onClick={(ev: Event) => {
+            {/**
+              * This is needed otherwise any click
+              * events set on `ion-item` are fired twice
+              */}
+            ev.preventDefault();
+            ev.stopPropagation()
+          }}
           type="checkbox"
           aria-checked={`${checked}`}
           disabled={disabled}