Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item click event not triggering if item contains checkbox #22557

Closed
luboslav opened this issue Nov 24, 2020 · 5 comments · Fixed by #22561 or #22573
Closed

bug: ion-item click event not triggering if item contains checkbox #22557

luboslav opened this issue Nov 24, 2020 · 5 comments · Fixed by #22561 or #22573
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@luboslav
Copy link

luboslav commented Nov 24, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
ion-item click event not triggering if item contains ion-checkbox

Expected behavior:
click event should be triggered

Steps to reproduce:
Stackblitz

Other information
It is a breaking change, it has worked in recent versions.

Ionic info:
ionic version: 5.5.0

@ionitron-bot ionitron-bot bot added the triage label Nov 24, 2020
@liamdebeasi
Copy link
Contributor

Thanks, I can reproduce this. Last good version was 5.4.4. Possibly related to 7214a84 but I have not confirmed that yet. cc @brandyscarney

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Nov 24, 2020
@ionitron-bot ionitron-bot bot removed the triage label Nov 24, 2020
@liamdebeasi liamdebeasi added this to the 5.5.1 milestone Nov 24, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #22561, and a fix will be available in an upcoming release of Ionic Framework.

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Nov 25, 2020

Hey there,

We discovered an issue with the fix in #22561, so I reverted it. I am going to re-open this issue until we can implement a proper fix.

As a workaround for now, you can add [button]="true" to your ion-item:

<ion-item [button]="true" (click)="myFunction()">
  <ion-checkbox></ion-checkbox>
</ion-item>

@liamdebeasi
Copy link
Contributor

@brandyscarney was able to come up with another solution, so this will still be fixed in an upcoming release of Ionic Framework. Thanks!

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 25, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
2 participants