Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ionic 4 textarea: MD design looks wrong #16187

Closed
brandyscarney opened this issue Nov 1, 2018 · 2 comments
Closed

Ionic 4 textarea: MD design looks wrong #16187

brandyscarney opened this issue Nov 1, 2018 · 2 comments
Assignees
@brandyscarney
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@brandyscarney
Copy link
Member

Material Design textarea doesn't look good in this test:

screen shot 2018-11-01 at 2 59 43 pm

I believe this is mostly attribute issues that need to be updated, maybe some styles as well
@ionitron-bot ionitron-bot bot added the triage label Nov 1, 2018
@brandyscarney brandyscarney changed the title textarea: MD design looks wrong Ionic 4 textarea: MD design looks wrong Nov 1, 2018
@brandyscarney brandyscarney added package: core @ionic/core package type: bug a confirmed bug report labels Dec 4, 2018
@ionitron-bot ionitron-bot bot removed the triage label Dec 4, 2018
@brandyscarney
Copy link
Member Author

Also need to look into the animation when value is changed on a floating label after a 1 second timeout. It is nonexistent there and if you up the timeout then it still looks off.

brandyscarney added a commit that referenced this issue Apr 15, 2019
@brandyscarney
fix(textarea): align label and textarea to baseline
cb18e61 
references #16187
@brandyscarney brandyscarney mentioned this issue Apr 15, 2019
Merged
13 tasks
@brandyscarney brandyscarney self-assigned this Apr 15, 2019
kiku-jw pushed a commit to kiku-jw/ionic that referenced this issue May 16, 2019
@brandyscarney @kiku-jw
fix(textarea): update label alignment for inputs and textareas (ionic…
6a9eda1 
…-team#18042)

- aligns label and textarea to baseline
- updates floating and stacked labels in items to align closer to the md spec

fixes ionic-team#16187
@ionitron-bot
Copy link

ionitron-bot bot commented May 16, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandyscarney