Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): update label alignment to baseline #18042

Merged
merged 10 commits into from
Apr 16, 2019
Merged

fix(textarea): update label alignment to baseline #18042

merged 10 commits into from
Apr 16, 2019

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Apr 15, 2019 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #16187

What is the new behavior?

  • Adds baseline alignment to labels and textarea in input items
  • Updates the MD label UI to be closer to the spec
  • Adds a spec test used to compare against the MD web implementation

Does this introduce a breaking change?

  • Yes
  • No

Other information

master branch
localhost_3333_src_components_textarea_test_basic(Galaxy S5) (6) localhost_3333_src_components_input_test_spec(Galaxy S5)
localhost_3333_src_components_textarea_test_basic(Galaxy S5) (5) localhost_3333_src_components_textarea_test_basic(Galaxy S5) (4)

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Apr 15, 2019
liamdebeasi
liamdebeasi reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one note:

There used to be a bit of space between the top of the textarea content and the label. It looks like that's no longer there:

master branch
Screen Shot 2019-04-16 at 8 31 35 AM Screen Shot 2019-04-16 at 8 32 04 AM

Note: This only happens on MD mode

@brandyscarney
Copy link
Member Author

@liamdebeasi Good catch! I'll look into it.

liamdebeasi
liamdebeasi approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🎉

@brandyscarney brandyscarney merged commit 38ae362 into master Apr 16, 2019
@brandyscarney brandyscarney deleted the fix-textarea-alignment branch April 16, 2019 18:57
kiku-jw pushed a commit to kiku-jw/ionic that referenced this pull request May 16, 2019
@brandyscarney @kiku-jw
fix(textarea): update label alignment for inputs and textareas (ionic…
6a9eda1 
…-team#18042)

- aligns label and textarea to baseline
- updates floating and stacked labels in items to align closer to the md spec

fixes ionic-team#16187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandyscarney @liamdebeasi