Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Search bar in toolbar not centered iOS #19495

Closed
LiveXenon opened this issue Sep 29, 2019 · 3 comments · Fixed by #19596
Closed

bug: Search bar in toolbar not centered iOS #19495

LiveXenon opened this issue Sep 29, 2019 · 3 comments · Fixed by #19596

Comments

@LiveXenon
Copy link

Bug Report

Ionic version:
5.4.1

Current behavior:
After updating the packages to the latest version I noticed that the search bar is no longer centered vertically.

Previous version of the package:

    "@ionic-native/native-storage": "^5.7.0",
    "@ionic-native/photo-viewer": "^5.12.0",
    "@ionic-native/splash-screen": "^5.0.0",
    "@ionic-native/status-bar": "^5.0.0",
    "@ionic-native/twitter-connect": "^5.7.0",
    "@ionic/angular": "^4.1.0",

Schermata 2019-09-29 alle 20 09 24

Schermata 2019-09-29 alle 20 08 25

Related code:
<ion-header> <ion-toolbar color="primary"> <ion-buttons slot="start"> <ion-back-button text=""></ion-back-button> </ion-buttons> <ion-searchbar placeholder="{{ 'searchUser' | translate }}" (ionChange)="search($event)" [debounce]="500"> </ion-searchbar> </ion-toolbar> </ion-header>

Ionic info:
Ionic:

Ionic CLI : 5.4.1 (/usr/local/lib/node_modules/ionic)
Ionic Framework : @ionic/angular 4.10.0
@angular-devkit/build-angular : 0.13.9
@angular-devkit/schematics : 7.3.9
@angular/cli : 7.3.9
@ionic/angular-toolkit : 1.5.1

Capacitor:

Capacitor CLI : 1.0.0
@capacitor/core : 1.0.0

Cordova:

Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : android 8.1.0, ios 5.0.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 20 other plugins)

Utility:

cordova-res : 0.3.0 (update available: 0.6.0)
native-run : 0.2.8

System:

ios-sim : 8.0.2
NodeJS : v10.15.0 (/usr/local/bin/node)
npm : 6.11.2
OS : macOS Mojave
Xcode : Xcode 10.3 Build version 10G8

@rossholdway
Copy link
Contributor

@LiveXenon Should be fixed in #19502

@brandyscarney
Copy link
Member

Thanks for the issue! The searchbar was moved to the top of the toolbar to match the iOS spec, see my comment here: #19502 (comment)

I'm adding a fix for the back button now.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 8, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants