Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Modal dismiss animation not smooth on latest ionic/angular #20697

Closed
DwieDima opened this issue Mar 5, 2020 · 7 comments
Closed

bug: Modal dismiss animation not smooth on latest ionic/angular #20697

DwieDima opened this issue Mar 5, 2020 · 7 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@DwieDima
Copy link
Contributor

DwieDima commented Mar 5, 2020

Bug Report

Ionic version:

[x] ^5.0.4

Current behavior:

Dismiss animation is flickering at the end of transition

Link to video

Expected behavior:

Dismiss animation should close smoothly
Steps to reproduce:
Just setup new ionic project using latest ionic and angular version (using Angular 9.0.2 at the moment)

Link to repo

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 6.1.0 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.4
   @angular-devkit/build-angular : 0.900.5
   @angular-devkit/schematics    : 9.0.5
   @angular/cli                  : 9.0.5
   @ionic/angular-toolkit        : 2.2.0

Capacitor:

   Capacitor CLI   : 1.3.0
   @capacitor/core : 1.3.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.16.0 (/usr/local/bin/node)
   npm    : 6.13.4
   OS     : macOS Catalina
@ionitron-bot ionitron-bot bot added the triage label Mar 5, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you provide some more information as to what device you are testing this on? Also the image/gif you tried to provide appears to be broken.

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Mar 5, 2020
@ionitron-bot ionitron-bot bot removed the triage label Mar 5, 2020
@DwieDima
Copy link
Contributor Author

DwieDima commented Mar 5, 2020

Thanks for the issue. Can you provide some more information as to what device you are testing this on? Also the image/gif you tried to provide appears to be broken.

Sorry for broken gif. I replaced it by a video link.
In the video i'm testing it on chrome browser.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Mar 5, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm i @ionic/angular@5.1.0-dev.202003051530.531d9e4

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Mar 5, 2020
@liamdebeasi liamdebeasi added this to the 5.0.5 milestone Mar 5, 2020
@ionitron-bot ionitron-bot bot removed the triage label Mar 5, 2020
@DwieDima
Copy link
Contributor Author

DwieDima commented Mar 5, 2020

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm i @ionic/angular@5.1.0-dev.202003051530.531d9e4

I get following error message by npm:

anon@anons-macbook-pro ionic-multiple-modal-bugs-master % npm i @ionic/angular@5.1.0
-dev.202003051530.531d9e4
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @ionic/angular@5.1.0-dev.202003051530.531d9e4.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/anon/.npm/_logs/2020-03-05T15_40_03_069Z-debug.log

@liamdebeasi
Copy link
Contributor

Try this dev build: 5.1.0-dev.202003051551.531d9e4.

@DwieDima
Copy link
Contributor Author

DwieDima commented Mar 6, 2020

Works! Thanks a lot! 👍

@ionitron-bot
Copy link

ionitron-bot bot commented Apr 5, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants