Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTL issues #17157

Closed
wants to merge 53 commits into from
Closed

Fix RTL issues #17157

wants to merge 53 commits into from

Conversation

abennouna
Copy link
Contributor

@abennouna abennouna commented Jan 18, 2019 •
edited
Loading

Short description of what this resolves:

Changes proposed in this pull request:

  • Float Elements: float-start, float-end, & their responsive versions (regression)
  • alert:
  • datetime
    • picker in iOS/MD: fix start/end columns’ horizontal positioning when there are 2 or 3 picker columns
    • with floating or stacked label: the datetime text should stay in the document flow (regression)
  • fab
    • horizontal position: position ion-fab correctly
  • label
    • position="floating" in iOS/MD: fix horizontal floating position relative to ion-item
  • menu
    • outer shadow in iOS/MD: invert shadows
  • popover
    • enter animation in MD: invert animation direction
  • progress-bar
    • default and reverse directions: both are the same; one of them should be inverted
    • indeterminate / buffer: fix animations
  • range
    • active range section in iOS/MD: fix position
    • knobs in iOS/MD: fix position
    • pins in MD: fix (background) position
  • searchbar
    • cancel icon in MD: invert horizontal position
    • clear icon in iOS: invert horizontal position
    • clear icon in MD: invert horizontal position
    • search icon in iOS: invert horizontal position
    • search icon in MD: invert horizontal position
  • segment
    • first and last buttons in iOS: fix borders
  • select
    • select icon in iOS: fix position of the inner element
  • tab-bar
    • badges: invert horizontal position
  • toggle
    • checked toggle in iOS / MD: the handle is off (regression)
    • swipe end on iOS: before gesture end, the handle looks off and goes beyond the left side

Ionic Version:

Fixes: #17012

abennouna and others added 17 commits December 14, 2018 15:43
@abennouna
Merge pull request #1 from ionic-team/master
6b20d3b 
chore(): update to latest master
@abennouna
Merge pull request #2 from ionic-team/master
af6b56a 
Merge pull request #2 from ionic-team/master
@abennouna
Merge pull request #3 from ionic-team/master
ce0664d 
pull updates
@abennouna
Merge pull request #4 from ionic-team/master
d560010 
Merge Master
@abennouna
Merge pull request #8 from ionic-team/master
6436971 
Pull master
@abennouna
Merge pull request #13 from ionic-team/master
b474223 
pull from `master`
@abennouna
Merge pull request #16 from ionic-team/master
4473bad 
pull `master`
@abennouna
Merge pull request #19 from ionic-team/master
4920d4c 
pull `master`
@abennouna
Merge pull request #21 from ionic-team/master
cd80b99 
pull `master`
@abennouna
Merge pull request #24 from ionic-team/master
8d88990 
pull `master`
@abennouna
Merge pull request #25 from ionic-team/master
25cde6f 
pull `master`
@abennouna
Merge pull request #27 from ionic-team/master
294abf3 
pull `master`
@abennouna
Merge pull request #30 from ionic-team/master
bcc306a 
pull `master`
@abennouna
Merge pull request #34 from ionic-team/master
88043d5 
pull `master`
fix(rtl): improve add-root-selector mixin
4c6d45c 
Sample usage with `position-horizontal` mixin
fix(fab): unset LTR positions in RTL mode
2987316
fix(toggle): use $shadowDom
24d9f15
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 18, 2019
@abennouna
Copy link
Contributor Author

@brandyscarney @adamdbradley requesting your reviews 🙏

@abennouna abennouna mentioned this pull request Jan 18, 2019
Closed
@abennouna abennouna changed the title [WIP] Fix RTL host context issues Fix RTL host context issues Jan 18, 2019
@abennouna abennouna changed the title Fix RTL host context issues Fix RTL issues Jan 20, 2019
@peterpeterparker peterpeterparker mentioned this pull request Feb 3, 2019
Closed
@abennouna
Copy link
Contributor Author

Closed in favor of split PRs

@abennouna abennouna closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abennouna @manucorporat