Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(core) icon change the font size to align ion segment button with icon #17751

Merged
merged 34 commits into from Apr 25, 2019
Merged

Fix(core) icon change the font size to align ion segment button with icon #17751

merged 34 commits into from Apr 25, 2019

Commits on Mar 11, 2019

  1. fix(core): modified icon font size

    @santoshyadavdev
    santoshyadavdev committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    9f948e0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/ionic-team/ionic into fix… 

    …(core)--icon-change-the-font-size-to-align-ion-segment-button-with-icon
    @santoshyadavdev
    santoshyadavdev committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    2653726 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. update test case and correct variable

    @santoshyadavdev
    santoshyadavdev committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    e7fd518 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    296fff7 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    f826fb7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    7d451cd View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. fix(datetime): default to local date (#17706)

    @liamdebeasi @santoshyadavdev
    liamdebeasi authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    fdcdbc5 View commit details
    Browse the repository at this point in the history

  2. fix(core): modified icon font size

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    17ad0cd View commit details
    Browse the repository at this point in the history

  3. update test case and correct variable

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    42e43b9 View commit details
    Browse the repository at this point in the history

  4. fix(datetime): fix edge cases with datetime and invalid values (#17769) 

    * fix edge cases with datetime and invalid values

* clean up code

* revert let changes

* run linter
    @liamdebeasi @santoshyadavdev
    liamdebeasi authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    7af7de7 View commit details
    Browse the repository at this point in the history

  5. chore(screenshot): slow down concurrent screenshot downloads (#17771)

    @adamdbradley @santoshyadavdev
    adamdbradley authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    89c7f50 View commit details
    Browse the repository at this point in the history

  6. fix(datetime): fix placeholder not being respected (#17772)

    @liamdebeasi @santoshyadavdev
    liamdebeasi authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    ffb16e7 View commit details
    Browse the repository at this point in the history

  7. fix(datetime): add additional checks for placeholders in angular (#17774 

    )
    @liamdebeasi @santoshyadavdev
    liamdebeasi authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    8406b5e View commit details
    Browse the repository at this point in the history

  8. fix(transition): animate all toolbars in iOS page transitions (#17224) 

    * fix(transition): add all header toolbars to ios transition

* test(nav): add 2nd toolbar to test transition

* fix(transition): add remaining toolbar children to animation

* fix(transition): fix incorrect variable name

* fix(toolbar): fix bug in safari, clean up code, update test

* fix typo

* change elems to els

* change Elem to El
    @zakton5 @santoshyadavdev
    zakton5 authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    d537e10 View commit details
    Browse the repository at this point in the history

  9. fix(chip): use transparent outline on color chips (#17719)

    @brandyscarney @santoshyadavdev
    brandyscarney authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    3f241f7 View commit details
    Browse the repository at this point in the history

  10. fix(platform): account for larger tablets (#17630) 

    * fix(platform): account for larger tablets

* lint files

* add utils file, clean up tests, add more tests

* update tests with extra desktop checks

* change window to win
    @liamdebeasi @santoshyadavdev
    liamdebeasi authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    e1fee16 View commit details
    Browse the repository at this point in the history

  11. fix(item-option): add styling for slots other than icon-only (#17711) 

    styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots.

- removes the e2e test from item/sliding in favor of all of them being under item-sliding
- adds more usage examples for all frameworks
- updates the styling for an anchor option so that it displays properly
- updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
- updates the interactive e2e test to work locally
- cleaned up the CSS for start/end icons
- verified the styles for ben approval 💪

closes #17737 fixes #17402
    @brandyscarney @santoshyadavdev
    brandyscarney authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    bab3294 View commit details
    Browse the repository at this point in the history

  12. fix(toggle): do not use the contrast color for toggle inner color (#1… 

    …7798)

fixes #17536
    @brandyscarney @santoshyadavdev
    brandyscarney authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    7413912 View commit details
    Browse the repository at this point in the history

  13. docs(tabs): correct ion-route property path to url (#17794)

    @jocubeit @santoshyadavdev
    jocubeit authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    7b6da69 View commit details
    Browse the repository at this point in the history

  14. fix(spinner): fix default spinner logic for relevant components (#17660) 

    - In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes #17659
    @abennouna @santoshyadavdev
    abennouna authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    866a09a View commit details
    Browse the repository at this point in the history

  15. fix(popover): update animation origin in RTL/MD (#17645) 

    Original main-axis origin fix was flawed in case of RTL.
Invert the animation’s main-axis origin in case the popover’s position is adjusted.

references #17012
    @abennouna @santoshyadavdev
    abennouna authored and santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    be32340 View commit details
    Browse the repository at this point in the history

  16. code review changes

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    0e2c9de View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' of https://github.com/ionic-team/ionic into fix… 

    …(core)--icon-change-the-font-size-to-align-ion-segment-button-with-icon
    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    2630331 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    59a069b View commit details
    Browse the repository at this point in the history

  19. Merge branch 'fix(core)--icon-change-the-font-size-to-align-ion-segme… 

    …nt-button-with-icon' of https://github.com/santoshyadav198613/ionic into fix(core)--icon-change-the-font-size-to-align-ion-segment-button-with-icon
    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    4cd616e View commit details
    Browse the repository at this point in the history

  20. lint errors

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    8b12904 View commit details
    Browse the repository at this point in the history

  21. lint errors

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    5c92d37 View commit details
    Browse the repository at this point in the history

  22. lint fix

    @santoshyadavdev
    santoshyadavdev committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    6fa11ce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. code review changes

    @santoshyadavdev
    santoshyadavdev committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    60c93dc View commit details
    Browse the repository at this point in the history

  2. fixed lint error

    @santoshyadavdev
    santoshyadavdev committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3ce6613 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    48c2afa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    ddbe46f View commit details
    Browse the repository at this point in the history

  2. fix(segment-button): update button flex properties to fill space 

    fixes #17069
    @brandyscarney
    brandyscarney committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    c371a26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix(core)--icon-change-the-font-size-to-al… 

    …ign-ion-segment-button-with-icon
    @brandyscarney
    brandyscarney committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    1982005 View commit details
    Browse the repository at this point in the history