Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(all): improve scroll assist responsiveness #20987

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20922

What is the new behavior?

  • Listen for keyboardWillShow event and reduced timeout from 1000 to 300ms

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Apr 7, 2020
@liamdebeasi liamdebeasi changed the title perf(): scroll assist now responds faster perf(): improve scroll assist responsiveness Apr 7, 2020
@liamdebeasi liamdebeasi changed the title perf(): improve scroll assist responsiveness perf(all): improve scroll assist responsiveness Apr 7, 2020
@liamdebeasi liamdebeasi merged commit 6f13b8c into master Apr 7, 2020
@liamdebeasi liamdebeasi deleted the scroll-assist-perf branch April 7, 2020 16:20
@danbn-100295
Copy link

Hi,can i update this ?
I try npm i @ionic/core@latest but it not work

@kevinboosten
Copy link

kevinboosten commented Aug 22, 2020

ionic scrollAssist

https://media0.giphy.com/media/h8rep5t6gaDFQBEmNZ/giphy.gif?cid=4d1e4f29a9d5245d9f14a44f921257f508e5194fb42d6b6e&rid=giphy.gif

@liamdebeasi was this PR related to the scroll behavior as we can see in this GIF? Because I'm still seeing this in several apps.
If so, I'll open a new bug issue with a demo repo.

@koczka
Copy link

koczka commented Sep 2, 2020

I'm still having this issue Boosten mentioned here.

Using

"@angular/core": "10.0.11"
"@capacitor/core": "2.4.0"
"@capacitor/ios": "2.4.0"
"@ionic/angular": "5.3.2"
"@ionic/core": "5.3.2"

@AAmeriyan
Copy link

Me too ,i'm having a delay after opening keyboard in ionic 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants