fix(item): only add click events to clickable items #22352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensodemann
approved these changes
Oct 21, 2020
liamdebeasi
reviewed
Oct 22, 2020
There was a problem hiding this comment.
My only concern about this is that we are making the click handler not reactive. If an item loads with no inputs then adds an input after a delay, this delegatesFocus function will never fire.
I can't imagine this is a common use case, but this PR would break that behavior.
|
I fixed Liam's concerns with adding an input later on. The event listener is now added in the |
liamdebeasi
approved these changes
Nov 4, 2020
TakumaKira
pushed a commit
to TakumaKira/ionic-framework
that referenced
this pull request
Nov 13, 2020
…team#22352) This stops screen readers, such as NVDA, from reading every item as clickable even when it is text only. fixes ionic-team#22011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev build:
5.5.0-dev.202010301640.9336349Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: fixes #22011
What is the new behavior?
Correctly announce items for screen readers, don't announce clickable when it is not
Does this introduce a breaking change?
Other information