feat(react): add custom elements bundle #23896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
liamdebeasi
changed the title
willmartian
approved these changes
Sep 9, 2021
| @@ -3,75 +3,142 @@ | |||
| /* auto-generated react proxies */ | |||
There was a problem hiding this comment.
Everything below this is still auto generated, correct?
There was a problem hiding this comment.
Awesome, everything looks good to me then (after CI passes). Good work 💯
|
A few things with the latest commits:
|
willmartian
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Ionic React now uses Stencil's custom elements bundle by default resulting in improved app load times, smaller bundle sizes, and compatibility with tooling such as Vite, ESBuild, and Rollup.
Does this introduce a breaking change?
Other information