chore(ci): fix stencil nightly job dependencies #27298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit updates the job dependency hierarchy for test-core-screenshot-legacy from `build-core` to `build-core-with-stencil-nightly`. the former is not a valid job name for the `stencil-nightly` workflow, likely just a copy/paste error
|
|
rwaskiewicz
changed the title
rwaskiewicz
commented
Apr 27, 2023
| @@ -98,7 +98,7 @@ jobs: | |||
| # to be the length of the shard array. | |||
| shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20] | |||
| totalShards: [20] | |||
| needs: [build-core] | |||
| needs: [build-core-with-stencil-nightly] | |||
There was a problem hiding this comment.
Alternatively, we could rename the job itself to build-core. The original intent was that when looking at the 'main' CI workflow for Framework, I found myself getting confused (was I looking at main.yml, or stencil-nightly.yml?). This served as an easier way to differentiate b/w the two. LMK if you'd prefer to make the s/build-core-with-stencil-nightly/build-core/ change
liamdebeasi
approved these changes
Apr 27, 2023
2 tasks
rwaskiewicz
added a commit
that referenced
this pull request
Apr 28, 2023
Issue number: # --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> the legacy screenshot test verification step can fail due to improper configuration ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> this commit updates the name of the legacy screenshot test so that we properly gate on verifying that the legacy tests passed ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information I tested this by kicking off the workflow - https://github.com/ionic-team/ionic-framework/actions/runs/4830665737 Yesterday, I [put up a PR](#27298) that did the same. However, I failed to verify it succeeded (since we don't gate on Stencil nightly) - only that it started (since that was the point of failure yesterday). Today, I have verified that it passes all the way through  <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The Stencil nightly job fails with the following error:
This started to fail last night. I believe this is a result of #27228, specifically this line 4fe8de7#diff-2f087e8fac034d51c50fc9350e10ceb4034298c16dd0d4f414f79d88ebb71aa0R101
What is the new behavior?
this commit updates the job dependency hierarchy for test-core-screenshot-legacy from
build-coretobuild-core-with-stencil-nightly. the former is not a valid job name for thestencil-nightlyworkflow, likely just a copy/paste errorDoes this introduce a breaking change?
Other information
To test this, I was able to kick off a version of this job with this branch: https://github.com/ionic-team/ionic-framework/actions/runs/4819613134 and saw the new/legacy screenshot tests running:
