Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump @stencil/core from 4.7.2 to 4.8.0 in /core #28586

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 27, 2023

Bumps @stencil/core from 4.7.2 to 4.8.0.

Release notes

Sourced from @鈥媠tencil/core's releases.

馃尀 v4.8.0 (2023-11-27)

Bug Fixes

  • hydrate: prevent dead code elimination of patch dom implementation (#4966) (5e36057)
  • mock-doc: add getAttributeNode to mock elements (#5070) (4e840e0)
  • mock-doc: add inert to HTMLAttributes (#5072) (71a4110), closes #5071
  • runtime: apply textnodes to shadow DOM instead of light DOM (#4946) (217d588)
  • test: pass jest args correctly for v28/29 (#5068) (5c4ac32)

Features

  • declarations: add popover attributes to JSX declarations (#5064) (f73aa14)
  • runtime: proxy form associated custom element lifecycle callbacks (#4939) (ca53dbb)

Thanks

馃帀 Thanks @鈥婬ansClaasen for their contributions! 馃帀

Changelog

Sourced from @鈥媠tencil/core's changelog.

馃尀 4.8.0 (2023-11-27)

Bug Fixes

  • hydrate: prevent dead code elimination of patch dom implementation (#4966) (5e36057)
  • mock-doc: add getAttributeNode to mock elements (#5070) (4e840e0)
  • mock-doc: add inert to HTMLAttributes (#5072) (71a4110), closes #5071
  • runtime: apply textnodes to shadow DOM instead of light DOM (#4946) (217d588)
  • test: pass jest args correctly for v28/29 (#5068) (5c4ac32)

Features

  • declarations: add popover attributes to JSX declarations (#5064) (f73aa14)
  • runtime: proxy form associated custom element lifecycle callbacks (#4939) (ca53dbb)
Commits
  • cddcad8 v4.8.0 (#5103)
  • bcb17ac docs(runtime): add interface docs to HostRef (#4871)
  • edc9f38 chore(deps): update dependency npm to v10.2.4 (#5085)
  • 49c7607 chore(deps): update typescript-eslint to v6.11.0 (#5087)
  • 9c8790d test(vdom): adding tests for insertVdomAnnotations (#4867)
  • 13ec78e chore(deps): update dependency puppeteer to v21.5.2 (#5086)
  • 9a3e81c chore(deps): update dependency @鈥媡ypes/node to v20.9.1 (#5084)
  • 217d588 fix(runtime): apply textnodes to shadow DOM instead of light DOM (#4946)
  • ca53dbb feat(runtime): proxy form associated custom element lifecycle callbacks (#4939)
  • 7c86019 refactor(build): stop removing process.binding in compiler (#5078)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 27, 2023
@github-actions github-actions bot added the package: core @ionic/core package label Nov 27, 2023
liamdebeasi added a commit that referenced this pull request Nov 28, 2023
I noticed that Dependabot PRs never had anyone assigned: #28586

The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. 

My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2023
I noticed that Dependabot PRs never had anyone assigned:
#28586

The reason was that we removed `* @ionic-team/framework` when we
adjusted the codeowners in
#27573.

My original reasoning for why we should remove it was wrong. GitHub only
assigns reviewers within a team if the team itself is assigned. By
removing the team from being reviewed, only people listed in the
codeowners file would be assigned. As an added example, PRs that do not
match codeowners currently have no one assigned:
#28430
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.7.2 to 4.8.0.
- [Release notes](https://github.com/ionic-team/stencil/releases)
- [Changelog](https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md)
- [Commits](ionic-team/stencil@v4.7.2...v4.8.0)

---
updated-dependencies:
- dependency-name: "@stencil/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/core/stencil/core-4.8.0 branch from 4cf5f07 to 283300c Compare November 29, 2023 16:21
@dependabot dependabot bot requested a review from a team as a code owner November 29, 2023 16:21
@dependabot dependabot bot requested review from liamdebeasi and removed request for a team November 29, 2023 16:21
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 34417a5 Nov 29, 2023
46 checks passed
@liamdebeasi liamdebeasi deleted the dependabot/npm_and_yarn/core/stencil/core-4.8.0 branch November 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant