feat(avatar): add styles for default (medium) size in ionic theme #29538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
brandyscarney
changed the title
2 tasks
thetaPC
previously requested changes
May 22, 2024
There was a problem hiding this comment.
Just thinking out loud, not part of this PR: I wonder if we there's a way for Playwright to not had that extra space. It makes it seem that it's part of the background of avatar.
There was a problem hiding this comment.
I don't see any extra space. Maybe it's the GitHub interface?
BenOsodrac
approved these changes
May 23, 2024
OS-giulianasilva
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Avatar does not have any styles in the ionic theme.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview