Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar): add styles for rectangular shape in ionic theme #29551

Merged
merged 15 commits into from
May 28, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented May 23, 2024

Issue number: internal


What is the current behavior?

Avatar does not have styles for the "rectangular" shape in the ionic theme.

What is the new behavior?

  • Adds the styles for the rectangular shape (border radius)
  • Adds e2e test for the rectangular shape

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 5:35pm

@github-actions github-actions bot added the package: core @ionic/core package label May 23, 2024
@brandyscarney brandyscarney marked this pull request as ready for review May 23, 2024 21:02
@brandyscarney brandyscarney requested a review from a team as a code owner May 23, 2024 21:02
Copy link

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @brandyscarney!

Base automatically changed from ROU-10738 to next May 28, 2024 17:25
@brandyscarney brandyscarney merged commit 8ebece3 into next May 28, 2024
47 checks passed
@brandyscarney brandyscarney deleted the ROU-10740 branch May 28, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants