Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ionicons): logo icons different from rest #1218

Closed
janpio opened this issue Aug 2, 2017 · 3 comments · Fixed by #1334
Closed

docs(ionicons): logo icons different from rest #1218

janpio opened this issue Aug 2, 2017 · 3 comments · Fixed by #1334

Comments

@janpio
Copy link
Contributor

janpio commented Aug 2, 2017

http://ionicframework.com/docs/ionicons/

If you search for something, you can normally always use the value from the "Name" column as the name of ion-icon: <ion-icon name="star"></ion-icon>.

This doesn't work for e.g. "twitter" or "twitch" where you have to use logo-twitter which is only visible after clicking the icon to get the popup.

This might be confusing (I know it was to me).

@beck24
Copy link

beck24 commented Aug 10, 2017

This caught me a couple of days ago...

@ciaran036
Copy link

This definitely needs to be documented. Something as simple as this shouldn't be left for us to scour Ionic forum posts for an answer for.

@leksinteractive
Copy link

I got tripped up on this one today as well.

I had a look at what's involved in updating the docs, setup this repo locally, ran gulp watch but then got stuck. Would it be just a matter of updating the icon 'keys' in this configuration file:

https://github.com/ionic-team/ionic-site/blob/master/content/docs/ionicons/site_data.json

Happy to update it if I could get some guidance?

danielsogl added a commit to danielsogl/ionic-site that referenced this issue Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants