Selector optimization #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please! |
|
We are working on a totally new build that isn't using Icomoon, and with that we will have faster selectors, and also SASS files get generated with the build, so since it's automatic we will probably include them. I'll see about getting LESS in there as well. I am going to close this mainly because we won't just be merging it in, but all of this will be in the next release of Ionicons coming soon. Thanks guys! |
|
Awesome.. and yes.. show some love to LESS as well.. :) |
|
+1 for LESS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as a fix for #7 - this requires the element to also contain the class
ionin addition to the icons. It also has the fix implemented for #11 as well. This is the fix that Font Awesome used.If support for LESS and/or SASS are not desired, you can easily cherrypick the commit of interest.