fix(icon): allow svg stroke to be passed in

[btsiders]

Related to ionic-team/ionic-framework#16483.

@brane53 asked that the stroke not be set at all, but I think setting it via a CSS var gives the most flexibility.

[ZachMoreno]

+1

[TomBourretViv]

Is there any news for this pull request ? I didn't find any solution to remove the default 'stroke' on my custom icons...

[patr0cl0]

I haven't find a way to remove the magic stroke as well. Would be cool if someone could look around at this PR please.

[btsiders]

I have no idea what happened to the code since the initial PR, but I have fixed it back up to not have any conflicts again.

[anagstef]

The way @btsiders implemented this does not introduce any breaking changes, but being able to turn stroke off is much needed. I think it should be merged.

[steebchen]

Can somebody please merge this? This is a must have for custom icons as it seems most of them are displayed incorrectly.

[anagstef]

@brandyscarney @liamdebeasi hey, i'm tagging you, cause maybe you have missed this Pull Request. It's a really important fix for custom icons. :)

[brandyscarney]

Thanks so much for the PR! I fixed this a little different, in the PR here: #688

Basically I removed stroke entirely since it shouldn't be there even for ionicons, and moved the fill to the host element which allows developers to override them without any CSS variables:

ion-icon {
  stroke: blue;
  fill: red;
}

I've released a dev build for this in Ionic, see my comment here: ionic-team/ionic-framework#16483 (comment)

Please comment on that issue if you see any problems, thanks again!!