Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): generate event type with inline types #412

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

sean-perkins
Copy link
Collaborator

@sean-perkins sean-perkins commented Jan 18, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When adding a custom event with an inline type:

@Event() ionSwipe!: EventEmitter<{ side: Side }>;

The generated event type is invalid:

 ionSwipe: EventEmitter<CustomEvent<IIonItemOptions{ side: IIonItemOptionsSide }>>;

There are two issues:

  1. The nested type argument is formatted incorrectly (missing <).
  2. The evaluated type shouldn’t include IIonItemOptions.

Expected output is:

ionSwipe: EventEmitter<CustomEvent<{ side: IIonItemOptionsSide }>>;

Issue URL: N/A

What is the new behavior?

  • The generated event type will account for inline-types.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 0.0.1-dev.11705624885.1949250b

@sean-perkins sean-perkins merged commit 5704cca into main Jan 25, 2024
3 checks passed
@sean-perkins sean-perkins deleted the sp/angular-inline-types branch January 25, 2024 22:35
jcfranco referenced this pull request in Esri/calcite-design-system Apr 5, 2024
….4 (#9037)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@stencil/angular-output-target](https://stenciljs.com/)
([source](https://togithub.com/ionic-team/stencil-ds-output-targets)) |
[`0.8.3` ->
`0.8.4`](https://renovatebot.com/diffs/npm/@stencil%2fangular-output-target/0.8.3/0.8.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fangular-output-target/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fangular-output-target/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fangular-output-target/0.8.3/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fangular-output-target/0.8.3/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ionic-team/stencil-ds-output-targets
(@&#8203;stencil/angular-output-target)</summary>

###
[`v0.8.4`](https://togithub.com/ionic-team/stencil-ds-output-targets/releases/tag/%40stencil/angular-output-target%400.8.4)

[Compare
Source](https://togithub.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...@stencil/angular-output-target@0.8.4)

#### What's Changed

- fix(angular): generate event type with inline types by
[@&#8203;sean-perkins](https://togithub.com/sean-perkins) in
[https://github.com/ionic-team/stencil-ds-output-targets/pull/412](https://togithub.com/ionic-team/stencil-ds-output-targets/pull/412)

**Full Changelog**:
https://github.com/ionic-team/stencil-ds-output-targets/compare/[@&#8203;stencil/angular-output-target](https://togithub.com/stencil/angular-output-target)[@&#8203;0](https://togithub.com/0).8.2...[@&#8203;stencil/angular-output-target](https://togithub.com/stencil/angular-output-target)[@&#8203;0](https://togithub.com/0).8.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Esri/calcite-design-system).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants