refactor(canvas-mock): add todataurl in canvas mock #2923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherP
changed the title
rwaskiewicz
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
I apologize that it took so long for a member of the team to take a look at this! If you're willing/able, I had a small ask to move the declaration for toDataURL. If not, I completely understand. Thanks again for you contribution, and again I apologize for the lack of response here
| @@ -372,6 +372,7 @@ export class MockCanvasElement extends MockHTMLElement { | |||
| data: new Array(w * h * 4), | |||
| }; | |||
| }, | |||
| toDataURL() {}, | |||
There was a problem hiding this comment.
I think this should be hoisted to be a method on MockCanvasMethod, rather than the object returned by getContext - it appears that toDataURL is an instance method on a Canvas element according to https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toDataURL (please let me know if my understanding is incorrect though!).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.