change puppeteer supported version ranges #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicewriteswrongs
added a commit
to ionic-team/stencil-site
that referenced
this pull request
Apr 7, 2022
This updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321. These changes are for stencil v3.
alicewriteswrongs
added a commit
to ionic-team/stencil-site
that referenced
this pull request
Apr 7, 2022
This updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. In short, we're going to drop support for any version of Puppeteer <10. This commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
LGTM - I had one comment on the docs that we should resolve, but I don't think that's a blocker for the v3 branch here
alicewriteswrongs
added a commit
to ionic-team/stencil-site
that referenced
this pull request
Apr 12, 2022
This updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. In short, we're going to drop support for any version of Puppeteer <10. This commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
alicewriteswrongs
added a commit
to ionic-team/stencil-site
that referenced
this pull request
Apr 12, 2022
This updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. In short, we're going to drop support for any version of Puppeteer <10. This commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Apr 12, 2022
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
that referenced
this pull request
Oct 3, 2022
this commit drops support for versions of puppeteer older than v10, and adds support for versions v11 thru v13. BREAKING CHANGE: Requires Puppeteer v10.0.0
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 20, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 23, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 25, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 25, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 25, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
rwaskiewicz
pushed a commit
to ionic-team/stencil-site
that referenced
this pull request
Jan 25, 2023
this updates the versions that we support for puppeteer to reflect changes proposed in ionic-team/stencil/pull/3321 for stencil v3. in short, we're going to drop support for any version of Puppeteer <10. this commit also condenses information about version 5-9 into one table cell, and adds columns for versions 11, 12, and 13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
This is only going to be included in v3, but for apps that migrate to v3, if they are using an older version of Puppeteer (<10) they'll need to upgrade it.
Testing
I did a little
npm run build && npm linkworkflow to test out these changes in a test component repo locally w/ various versions of Puppeteer. I confirmed that: