Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Filename fingerprint/hash pointed from app.js (es5) remains same even when content updated #5011

Open
3 tasks done
Aadhisivam opened this issue Nov 1, 2023 · 4 comments
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@Aadhisivam
Copy link

Aadhisivam commented Nov 1, 2023

Prerequisites

Stencil Version

3.0.1

Current Behavior

ES5 - app.js pointing to some map file which has file-path for each components, whose fingerprint/hash remains same even when the contents inside changed.
image

When using app.js as script src.. couldn't get the latest components from cdn as filename remains same.
Tested with v3 and v4 both has the issue.

Expected Behavior

Filename to be dynamic based on content sha.

System Info

No response

Steps to Reproduce

Code Reproduction URL

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Nov 1, 2023
@rwaskiewicz rwaskiewicz added the ionitron: needs reproduction This PR or Issue does not have a reproduction case URL label Nov 1, 2023
Copy link

ionitron-bot bot commented Nov 1, 2023

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

@ionitron-bot ionitron-bot bot removed the triage label Nov 1, 2023
@Aadhisivam
Copy link
Author

Please check this repo https://github.com/Unluckynerd/Stencil-Components/

For reproduction:

  1. yarn build from main branch : https://github.com/Unluckynerd/Stencil-Components/tree/main

  2. Navigate to dist/stencil-example/stencil-example.js it has filename ref to p-4d29357c.system.js

  3. yarn build from patch_add_newButton branch : https://github.com/Unluckynerd/Stencil-Components/tree/patch_add_newButton

  4. Navigate to dist/stencil-example/stencil-example.js, it has same filename referencep-4d29357c.system.js, but if we compare the contents of p-4d29357c.system.js it will be different.

Filename remains same for these branches.

Version used:
Stencil v4.7.0
node v18.18.0

@rwaskiewicz rwaskiewicz added triage and removed ionitron: needs reproduction This PR or Issue does not have a reproduction case URL labels Nov 3, 2023
@tanner-reits tanner-reits self-assigned this Nov 7, 2023
@tanner-reits
Copy link
Member

@Aadhisivam I was able to confirm what you're seeing. I'll get this labeled and ingested into our backlog for future work!

@tanner-reits tanner-reits removed their assignment Nov 7, 2023
@tanner-reits tanner-reits added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed triage labels Nov 7, 2023
@alicewriteswrongs
Copy link
Contributor

Did a little investigation on this. The hashes that are used as filenames are generated by Rollup, so Stencil doesn't directly control how that works. I believe this issue maybe have something to do with rollup/rollup#2839, but I haven't conclusively determined that to be the case. It's possible that upgrading to Rollup v3 will fix the issue (and we may not be able to fix it without doing that unfortunately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

No branches or pull requests

4 participants