Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): provide second arg to insertBefore #5933

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

tanner-reits
Copy link
Member

What is the current behavior?

GitHub Issue Number: N/A

The runtime will throw an error when trying to apply styles to a Shadow component

What is the new behavior?

Styles will be applied without throwing an error

Documentation

N/A

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@tanner-reits tanner-reits requested a review from a team as a code owner August 8, 2024 17:53
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks a lot!

@christian-bromann christian-bromann added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit afcc9a5 Aug 9, 2024
88 checks passed
@christian-bromann christian-bromann deleted the tr/fix-append-styles branch August 9, 2024 03:18
@christian-bromann
Copy link
Member

This patch has been published in Stencil v4.21.0!

@bkjohnson
Copy link

I think this might have caused a regression. When I upgrade stencil to 4.21.0 and do a build, I get a runtime error which causes tests to fail:


          Ferrum::JavaScriptError:
            NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
                at addStyle

@tanner-reits
Copy link
Member Author

@bkjohnson If you have a reproduction case I can take a peek

@bkjohnson
Copy link

I couldn't isolate the issue enough to create a reproduction, but I've just upgraded to 4.22.1 successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants