Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in FullNameExternalAutocomplete default value #1196

Merged

Conversation

MrLuje
Copy link
Contributor

@MrLuje MrLuje commented Nov 9, 2023

WHAT

🤖 Generated by Copilot at ea165ed

Fix a bug in FullNameExternalAutocomplete setting for LSP. Use the correct value from the dto parameter in FromDto method in src/FsAutoComplete/LspHelpers.fs.

🤖 Generated by Copilot at ea165ed

FullNameExternal
Autocomplete bug is fixed
Winter of errors

🐛🔧📝

WHY

New FullNameExternalAutocomplete feature (#1178) might be initialized with the wrong default value

HOW

🤖 Generated by Copilot at ea165ed

  • Fix bug in FullNameExternalAutocomplete setting (link)

@baronfel
Copy link
Contributor

baronfel commented Nov 9, 2023

Thank you!

@baronfel baronfel merged commit 3b6a025 into ionide:main Nov 9, 2023
12 of 13 checks passed
@MrLuje MrLuje deleted the fix/fullname-external-autocomplete-typo branch November 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants