Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sender): write on closed pipe err #176

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

tarrencev
Copy link
Collaborator

Handle io.ErrClosedPipe more gracefully.

We should simplify how we are closing senders. It should be triggered by the p.pc.RemoveTrack call, rather than the other way around.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #176 into master will increase coverage by 0.22%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   71.83%   72.05%   +0.22%     
==========================================
  Files           8        8              
  Lines         845      841       -4     
==========================================
- Hits          607      606       -1     
+ Misses        200      197       -3     
  Partials       38       38              
Impacted Files Coverage Δ
pkg/receiver.go 53.58% <ø> (+0.06%) ⬆️
pkg/sender.go 89.81% <66.66%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed685a...274ca12. Read the comment docs.

@OrlandoCo
Copy link
Collaborator

We should simplify how we are closing senders. It should be triggered by the p.pc.RemoveTrack call, rather than the other way around.

According to this comit from Pion/Webrtc we should close the sender when a io.EOF it's recieved from the webrtc.Track#Read(), Currently now we are closing senders only on peer disconnecting /failing

@tarrencev tarrencev merged commit 22b33c4 into master Sep 16, 2020
@tarrencev tarrencev deleted the fix/sender_write_on_closed branch September 16, 2020 17:12
leewardbound pushed a commit to leewardbound/ion-sfu that referenced this pull request Nov 1, 2020
Docker copy path

Former-commit-id: 4151496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants