This repository has been archived by the owner on Dec 2, 2023. It is now read-only.
Upgraded WebPack to version 4.x #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dreamerns
referenced
this pull request
in cryptagon/ion
Aug 12, 2020
* support jwt auth * readme * Fix blocking call to start NewWebSocketServer preventing main() * Launch biz serviceWatcher in bg (like other nodes) * Rework auth config structure, add support for room auth, add support for key validation * Update naming connectionAuth (more consistent) * Fix assignment typo * Add some debug logging * Use interface for authenticatable test on msg, add example key * Fix connection auth (use mapClaims) * Add authentication support to kubernetes chart * Update docs * Simplify claims Co-authored-by: Tarrence van As <tarrence13@gmail.com>
billylindeman
pushed a commit
to billylindeman/ion
that referenced
this pull request
Sep 11, 2020
* Allow rejoining the room with different peer Currently we are ignoring join message from participant who already joined the room. This is causing issue in case where participant lost connectivity and needed to open new websocket (ip address change for example). In this PR we will kick out old participant in that case, close the transport and use new peer to relay messages to. * address possible npe
adwpc
pushed a commit
that referenced
this pull request
Oct 19, 2020
…criptions (#413) * Auth (#1) * support jwt auth * readme * Fix blocking call to start NewWebSocketServer preventing main() * Launch biz serviceWatcher in bg (like other nodes) * Rework auth config structure, add support for room auth, add support for key validation * Update naming connectionAuth (more consistent) * Fix assignment typo * Add some debug logging * Use interface for authenticatable test on msg, add example key * Fix connection auth (use mapClaims) * Add authentication support to kubernetes chart * Update docs * Simplify claims Co-authored-by: Tarrence van As <tarrence13@gmail.com> * cb4597 - Allow rejoining the room with different peer (#1) * Allow rejoining the room with different peer Currently we are ignoring join message from participant who already joined the room. This is causing issue in case where participant lost connectivity and needed to open new websocket (ip address change for example). In this PR we will kick out old participant in that case, close the transport and use new peer to relay messages to. * address possible npe * Add config values in kube chart for pli/remb cycle * Add config options * Use updated 264 profile for ExternalEncoder * cb5993 Fix stale subscriptions (#4) * Handle websocket closure (#2) When websocket is connection is lost, protoo sometimes sends 100 error code (instead of 100x). This ends up not removing client from the room. As consequence client is left spinning indefinitelly. * Fix stale subscriptions * remove that >100 change that exists in twilight zone * Syncing all streams on join (#5) Co-authored-by: Billy Lindeman <billylindeman@gmail.com> Co-authored-by: Tarrence van As <tarrence13@gmail.com> Co-authored-by: Nikola Novakovic <dreamerns@gmail.com> Co-authored-by: Tim Su <tim@tandem.chat>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded WebPack to version 4.x
Reference issue