feat(vlan): Add vlan tag support for VM reconcile. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implement VLAN tag support when creating - or more in general reconciling - a ProxmoxMachine. This feature implements a new optional value in the ProxmoxMachine CRS, defined in the NetworkDevice type. The value is an integer, delimited in the range 1-4094. Tests have been also implemented to prevent regression, and e2e tests have been conducted creating both cluster using the new property and without - to check past compat.
CiraciNicolo
requested review from
65278,
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
|
It would be possibile to have access to the SonarQube report? Thanks. |
avorima
reviewed
Mar 12, 2024
| return nil | ||
| } | ||
|
|
||
| func validateNetworkDeviceVLAN(device *infrav1.NetworkDevice) error { |
There was a problem hiding this comment.
This is already covered by the OpenAPI spec, so you can remove it.
|
Hi, I've refactored the code as you suggested, and pulled the latest changes from main 😊 |
|
Please rebase. I will let @avorima finish the review. |
|
please rebase, to get it merged) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit implement VLAN tag support when creating - or more in general reconciling - a ProxmoxMachine. This feature implements a new optional value in the ProxmoxMachine CRS, defined in the NetworkDevice type. The value is an integer, delimited in the range 1-4094.
Testing performed:
Tests have been also implemented to prevent regression, and e2e tests have been conducted creating both cluster using the new property and without - to check past compat.