Upgrade ipam to 0.1.0 and capi to 1.6.3 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbenjemaa
requested review from
65278,
avorima,
lubedacht,
pborn-ionos and
wikkyk
as code owners
|
closes #121 |
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
27ee273
to
16e1318
Compare
|
Closes #136 |
wikkyk
approved these changes
Mar 14, 2024
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
16e1318
to
fa33ee7
Compare
mcbenjemaa
commented
Mar 14, 2024
| replace sigs.k8s.io/cluster-api => sigs.k8s.io/cluster-api v1.6.1 | ||
| replace sigs.k8s.io/cluster-api => sigs.k8s.io/cluster-api v1.6.3 | ||
|
|
||
| replace github.com/google/cel-go => github.com/google/cel-go v0.17.8 |
There was a problem hiding this comment.
I added this to fix the circular dependency caused by the k8s api v1.29
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
fa33ee7
to
d4cf929
Compare
|
@wikkyk, you can approve and merge once the e2e test is successfully finished. |
|
Ready |
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
d4cf929
to
cd6280b
Compare
|
@avorima I shall request your eyes again. |
avorima
reviewed
Mar 20, 2024
config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclusters.yaml
Outdated
Show resolved
Hide resolved
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
9388f67
to
5f2a284
Compare
mcbenjemaa
force-pushed
the
capi-runtime
branch
from
5f2a284
to
d23fede
Compare
|
Ready |
avorima
reviewed
Mar 21, 2024
avorima
previously approved these changes
Mar 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #116
Description of changes:
Update deps of ipam and capi.
Testing performed:
Created new cluster ✅