Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context functions): expose core functions for ease of use #14

Merged
merged 2 commits into from
May 3, 2018

Conversation

coreylight
Copy link
Contributor

By exposing functions like mark, metric, and label at the module level,
consumers of this library will have an easier time using those features.

By exposing functions like mark, metric, and label at the module level,
consumers of this library will have an easier time using those features.
@coreylight coreylight requested review from kolanos and pselle May 1, 2018 14:24
- [IOpipe Documentation](https://github.com/iopipe/iopipe-js-core#readme)
- [IOpipe Tracing Plugin Documentation](https://github.com/iopipe/iopipe-plugin-trace#readme)

Example With Tracing, Custom Metrics, and Labels (ES6 Module Format):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

pselle
pselle previously approved these changes May 1, 2018
kolanos
kolanos previously approved these changes May 1, 2018
@coreylight
Copy link
Contributor Author

@pselle @kolanos I realized I left .log in here, I'm thinking it should be removed as it is deprecated?

@pselle
Copy link
Contributor

pselle commented May 2, 2018

@coreylight ah, didn't catch that. Yes, I think you could remove that from the exports

@coreylight coreylight dismissed stale reviews from pselle and kolanos May 2, 2018 17:42

outdated

@coreylight
Copy link
Contributor Author

@pselle @kolanos back in review - removed .log export.

@coreylight coreylight requested review from kolanos and pselle May 2, 2018 17:42
@coreylight coreylight merged commit dc6033d into iopipe:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants