Skip to content

Commit

Permalink
Prevent CL_RunCinematic from reading cinTable[-1]
Browse files Browse the repository at this point in the history
At the end of CL_RunCinematic, RoQShutdown sets currentHandle to -1.
This causes the return at the end to be return cinTable[-1].status.
Use return FMV_EOF when RoQShutdown is called.

I think FMV_EOF should be returned instead of FMV_IDLE which is set in
RoQShutdown because RoQShutdown is clearing out state so it can be reused
for a new cinematic.

The return value isn't actually read by the ioq3 client, renderers,
cgame, or ui.
  • Loading branch information
zturtleman committed Jun 15, 2016
1 parent 0334f4a commit 780f0a5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions code/client/cl_cin.c
Original file line number Diff line number Diff line change
Expand Up @@ -1384,6 +1384,7 @@ e_status CIN_RunCinematic (int handle)
RoQReset();
} else {
RoQShutdown();
return FMV_EOF;
}
}

Expand Down

0 comments on commit 780f0a5

Please sign in to comment.