Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret drop #103

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Secret drop #103

merged 3 commits into from
Jul 16, 2020

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Jul 15, 2020 •
edited
Loading

Description of change

Adds a derive macro to implement Drop on secret types.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

How the change has been tested

Locally tested.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added c-feature Category - Feature e-medium Experience - Medium p-high Priority - High s-blocked wg-common Working Group - Common labels Jul 15, 2020
@thibault-martinez thibault-martinez marked this pull request as ready for review July 16, 2020 13:00
@samuel-rufi samuel-rufi self-requested a review July 16, 2020 15:00
@thibault-martinez thibault-martinez merged commit 1f89702 into iotaledger:master Jul 16, 2020
@thibault-martinez thibault-martinez mentioned this pull request Jul 16, 2020
Closed
@thibault-martinez thibault-martinez deleted the secret-drop branch March 16, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
c-feature Category - Feature e-medium Experience - Medium p-high Priority - High wg-common Working Group - Common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-martinez @zesterer @samuel-rufi @Alex6323