Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source-based code coverage #451

Merged
merged 10 commits into from
Mar 10, 2021
Merged

Source-based code coverage #451

merged 10 commits into from
Mar 10, 2021

Conversation

Adam-Gleave
Copy link
Contributor

@Adam-Gleave Adam-Gleave commented Mar 5, 2021 •
edited
Loading

Description of change

New test coverage action using Cargo's source-based coverage tools. This can also be run locally using the bash script with the repository root as the working directory.

Links to any relevant issues

Addresses issue #438.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

The workflow has been run on my fork and passed, with test coverage for all Bee crates: results here.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Adam-Gleave Adam-Gleave linked an issue Mar 5, 2021 that may be closed by this pull request
Investigate code coverage #438
Closed
nothingismagick
nothingismagick suggested changes Mar 10, 2021
View reviewed changes
.github/workflows/scripts/coverage.sh Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
.github/workflows/scripts/coverage.sh Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Show resolved Hide resolved
@nothingismagick nothingismagick mentioned this pull request Mar 10, 2021
Closed
Adam Gleave and others added 2 commits March 10, 2021 11:40
@nothingismagick
Apply suggestions from code review (full bash path, trailing newline)
4fe5162 
Co-authored-by: nothingismagick <drthompsonsmagickindustries@gmail.com>
@Adam-Gleave
Add paths filter, remove chmod
1a619e5
@rajivshah3
Copy link
Member

Nice! I was considering doing the same for wallet.rs as grcov hasn't been too reliable

rajivshah3
rajivshah3 previously approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I might have to steal this 😄

.github/workflows/coverage.yml Show resolved Hide resolved
@rajivshah3
Add workflow files to coverage triggers
0a22e23 
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
@thibault-martinez thibault-martinez merged commit 48b73fd into iotaledger:dev Mar 10, 2021
@rajivshah3 rajivshah3 mentioned this pull request Mar 18, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@rajivshah3 rajivshah3 rajivshah3 left review comments

@nothingismagick nothingismagick nothingismagick left review comments

@Alex6323 Alex6323 Awaiting requested review from Alex6323 Alex6323 is a code owner

@zesterer zesterer Awaiting requested review from zesterer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate code coverage
4 participants
@Adam-Gleave @rajivshah3 @thibault-martinez @nothingismagick