Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple send_message calls to work simultaneously #1203

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

melatron
Copy link
Contributor

@melatron melatron commented Jun 14, 2021

Description of change

  1. Removed the block_on pattern in which the tokio runtime was called guarded with a mutex. Currently we spawn tasks for each async call.
  2. Removed the mutex which prevented to make simultaneous calls.
  3. Changed wallet.rs version, so that we can call handle from multiple tokio tasks simultaneously.
  4. Change function arguments in shared/lib/typings/account.ts to match those with the wallet.rs API (specifically this method)

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@melatron melatron requested a review from laumair June 14, 2021 08:31
@melatron melatron requested a review from Thoralf-M June 14, 2021 10:02
@melatron melatron requested a review from Thoralf-M June 14, 2021 11:50
@cvarley100 cvarley100 merged commit 5acfa69 into develop Jun 22, 2021
@cvarley100 cvarley100 deleted the fix/blocking-send-message branch June 22, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants