New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: best time duration function #1826

Merged

cvarley100 merged 1 commit into develop from hotfix/best-time-duration-function

Dec 30, 2021

Contributor

maxwellmattryan commented Dec 21, 2021 •

edited

Loading

Description of change

Fixes the logic for getBestTimeDuration (time.ts) to return the correct number
Fixes test in time.test.ts

Links to any relevant issues

None

Type of change

Fix (a change which fixes an issue)

How the change has been tested

Platforms:

MacOS (10.15.7)

Cases:

Try various amounts of time (negative, zero, near-zero, and non-zero)

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that my latest changes pass CI tests
New and existing unit tests pass locally with my changes


          fix: Fix logic for passing number to localize function

03a91e4

maxwellmattryan added type:hotfix scope:shared labels

maxwellmattryan self-assigned this

maxwellmattryan requested a review from cvarley100 as a code owner

December 21, 2021 14:35

cvarley100 approved these changes

View reviewed changes

cvarley100 merged commit 91ef08e into develop

cvarley100 deleted the hotfix/best-time-duration-function branch

December 30, 2021 14:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels