New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deep link opens already registered proposal #5701
feat: deep link opens already registered proposal #5701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good! Just have a few changes 🙏
...lib/auxiliary/deep-link/handlers/governance/operations/handleDeepLinkAddProposalOperation.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalsFromEvents.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/getProposalFromEventId.ts
Outdated
Show resolved
Hide resolved
...lib/auxiliary/deep-link/handlers/governance/operations/handleDeepLinkAddProposalOperation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requested changes, but looks good! Going to build and test
...file/views/settings/views/networkConfiguration/views/NetworkConfigurationNodeInfoView.svelte
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalFromEvent.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalFromEvent.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalFromEvent.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposals.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposals.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalFromEvent.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/getProposalFromEventId.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny requested changes about imports 😅
packages/shared/lib/contexts/governance/constants/default-proposal-filter.constant.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/contexts/governance/utils/getProposalFromEventId.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
* feat: deep link opens already registered proposal * fixes from review * try to prevent edge cases * fixes after merge * fix code convention import order * update import * fix: getProposalFromEventId * format fixes * fix tests failing * fix: importing coding conventions * change importing order in createProposalFromEvent * fix relative imports * fix: moves condition of selectedProposalId to only wrap the set store line * fix: remove global flag from proposal ID regexp --------- Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
* feat: deep link opens already registered proposal * fixes from review * try to prevent edge cases * fixes after merge * fix code convention import order * update import * fix: getProposalFromEventId * format fixes * fix tests failing * fix: importing coding conventions * change importing order in createProposalFromEvent * fix relative imports * fix: moves condition of selectedProposalId to only wrap the set store line * fix: remove global flag from proposal ID regexp --------- Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
* New Crowdin translations by Github Action * feat: deep link opens already registered proposal (#5701) * feat: deep link opens already registered proposal * fixes from review * try to prevent edge cases * fixes after merge * fix code convention import order * update import * fix: getProposalFromEventId * format fixes * fix tests failing * fix: importing coding conventions * change importing order in createProposalFromEvent * fix relative imports * fix: moves condition of selectedProposalId to only wrap the set store line * fix: remove global flag from proposal ID regexp --------- Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: undefined param get percentages (#5719) * fix: undefined param get percentages * fix: setWinnerAnswerIndex undefined answerStatuses * fix: revert breaking change in i18n (#5720) Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> * feat-mobile: balance breakdown (#5689) * feat: kickoff account actions drawer * fix: features * feat: add customize account * feat: toggle account visibility * feat: delete account * feat: balance breakdown * feat: finalize output consolidation --------- Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * fix: require at least one answer (#5718) * fix: adjust logic to automatically abstain * fix: PR fixes --------- Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> * feat: governance polishing #2 (#5723) * fix: NodeInput selector not overflowing popup * fix: removes OrderFilterItem mb-4 * fix: ProposalCard height with falsy status * fix: question not collapsing * feat: add a decimal place to the proposal answers percentages where is needed * fix: consistent tooltip styling * fix: do not freeze on negative participation range (#5733) * fix: do not freeze on negative participation range Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> * refactor: move logic into separate function --------- Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * fix: add pending activity for voting (#5721) * fix: add pending activity on voting * chore: use correct error handling * fix: update participation overview when vote is included * refactor: simplify processAndAddToActivities * chore: update locales --------- Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Tuditi <daviddetroch@pm.me> * fix: reset Governance dashboard on wallet switch (#5737) * fix: add account switching for proposal details view * chore: rename some components * fix: allow switching on dashboard view * chore: add explanatory comments * chore: apply changes per PR review * fix: fix details view if account with proposal gets deleted (#5739) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Summary
Clicking on a deep link to register a proposal that was already registered should open it automatically.
Relevant Issues
closes #5669
Testing
Platforms
Checklist