Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset Governance dashboard on wallet switch #5737

Merged
merged 5 commits into from Feb 1, 2023
Merged

fix: reset Governance dashboard on wallet switch #5737

merged 5 commits into from Feb 1, 2023

Conversation

maxwellmattryan
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

This fixes some bugs with switching wallets while in the Governance views.

Changelog

- Added reactive dependencies on selectedAccountIndex to switch the router and reset proposals
- Fixed reactive dependency logic in Collectibles tab
- Renamed Governance view components to be more descriptive

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Register different proposals for two accounts and switch between them, from multiple views.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan self-assigned this Feb 1, 2023
@maxwellmattryan maxwellmattryan linked an issue Feb 1, 2023 that may be closed by this pull request
[Task]: Reset Governance dashboard on wallet switch #5727
Closed
7 tasks
MarkNerdi996
MarkNerdi996 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 545eb27 into develop Feb 1, 2023
@MarkNerdi996 MarkNerdi996 deleted the fix/reset-governance-dashboard-on-wallet-switch branch February 1, 2023 16:56
Tuditi pushed a commit that referenced this pull request Feb 1, 2023
@maxwellmattryan @Tuditi
fix: reset Governance dashboard on wallet switch (#5737)
c5f064a 
* fix: add account switching for proposal details view

* chore: rename some components

* fix: allow switching on dashboard view

* chore: add explanatory comments

* chore: apply changes per PR review
Tuditi pushed a commit that referenced this pull request Feb 1, 2023
@maxwellmattryan @Tuditi
fix: reset Governance dashboard on wallet switch (#5737)
d8050df 
* fix: add account switching for proposal details view

* chore: rename some components

* fix: allow switching on dashboard view

* chore: add explanatory comments

* chore: apply changes per PR review
Tuditi added a commit that referenced this pull request Feb 1, 2023
@github-actions @crowdin-bot
@jeeanribeiro @maxwellmattryan @nicole-obrien @begonaalvarezd @paul-boegelsack @Tuditi @MarkNerdi996
New translations [ci skip] (#5652)
aee297e 
* New Crowdin translations by Github Action

* feat: deep link opens already registered proposal (#5701)

* feat: deep link opens already registered proposal

* fixes from review

* try to prevent edge cases

* fixes after merge

* fix code convention import order

* update import

* fix: getProposalFromEventId

* format fixes

* fix tests failing

* fix: importing coding conventions

* change importing order in createProposalFromEvent

* fix relative imports

* fix: moves condition of selectedProposalId to only wrap the set store line

* fix: remove global flag from proposal ID regexp

---------

Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: undefined param get percentages (#5719)

* fix: undefined param get percentages

* fix: setWinnerAnswerIndex undefined answerStatuses

* fix: revert breaking change in i18n (#5720)

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

* feat-mobile: balance breakdown (#5689)

* feat: kickoff account actions drawer

* fix: features

* feat: add customize account

* feat: toggle account visibility

* feat: delete account

* feat: balance breakdown

* feat: finalize output consolidation

---------

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* fix: require at least one answer (#5718)

* fix: adjust logic to automatically abstain

* fix: PR fixes

---------

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>

* feat: governance polishing #2 (#5723)

* fix: NodeInput selector not overflowing popup

* fix: removes OrderFilterItem mb-4

* fix: ProposalCard height with falsy status

* fix: question not collapsing

* feat: add a decimal place to the proposal answers percentages where is needed

* fix: consistent tooltip styling

* fix: do not freeze on negative participation range (#5733)

* fix: do not freeze on negative participation range

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>

* refactor: move logic into separate function

---------

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* fix: add pending activity for voting (#5721)

* fix: add pending activity on voting

* chore: use correct error handling

* fix: update participation overview when vote is included

* refactor: simplify processAndAddToActivities

* chore: update locales

---------

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* fix: reset Governance dashboard on wallet switch (#5737)

* fix: add account switching for proposal details view

* chore: rename some components

* fix: allow switching on dashboard view

* chore: add explanatory comments

* chore: apply changes per PR review

* fix: fix details view if account with proposal gets deleted (#5739)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@Tuditi Tuditi Awaiting requested review from Tuditi

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@maxwellmattryan maxwellmattryan

Labels
context:governance context:navigation type:fix Fix for bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Reset Governance dashboard on wallet switch
2 participants
@maxwellmattryan @MarkNerdi996