fix: fix details view if account with proposal gets deleted #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tuditi
added a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Tuditi
added a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Tuditi
added a commit
that referenced
this pull request
Feb 1, 2023
* New Crowdin translations by Github Action * feat: deep link opens already registered proposal (#5701) * feat: deep link opens already registered proposal * fixes from review * try to prevent edge cases * fixes after merge * fix code convention import order * update import * fix: getProposalFromEventId * format fixes * fix tests failing * fix: importing coding conventions * change importing order in createProposalFromEvent * fix relative imports * fix: moves condition of selectedProposalId to only wrap the set store line * fix: remove global flag from proposal ID regexp --------- Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: undefined param get percentages (#5719) * fix: undefined param get percentages * fix: setWinnerAnswerIndex undefined answerStatuses * fix: revert breaking change in i18n (#5720) Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> * feat-mobile: balance breakdown (#5689) * feat: kickoff account actions drawer * fix: features * feat: add customize account * feat: toggle account visibility * feat: delete account * feat: balance breakdown * feat: finalize output consolidation --------- Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * fix: require at least one answer (#5718) * fix: adjust logic to automatically abstain * fix: PR fixes --------- Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> * feat: governance polishing #2 (#5723) * fix: NodeInput selector not overflowing popup * fix: removes OrderFilterItem mb-4 * fix: ProposalCard height with falsy status * fix: question not collapsing * feat: add a decimal place to the proposal answers percentages where is needed * fix: consistent tooltip styling * fix: do not freeze on negative participation range (#5733) * fix: do not freeze on negative participation range Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> * refactor: move logic into separate function --------- Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * fix: add pending activity for voting (#5721) * fix: add pending activity on voting * chore: use correct error handling * fix: update participation overview when vote is included * refactor: simplify processAndAddToActivities * chore: update locales --------- Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Tuditi <daviddetroch@pm.me> * fix: reset Governance dashboard on wallet switch (#5737) * fix: add account switching for proposal details view * chore: rename some components * fix: allow switching on dashboard view * chore: add explanatory comments * chore: apply changes per PR review * fix: fix details view if account with proposal gets deleted (#5739) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The error in the image is caused because by removing an account, it only updates the
activeAccountsstore, but not theprofile.metadata(somehow even on loggout). Therefore, if an account had a proposal registered, and is then removed, the error{type: "accountNotFound", text: "12"}gets thrownChangelog
Relevant Issues
Please list any related issues (e.g. bug, task).
Testing
Platforms
Instructions
...
Checklist