Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: governance polishing #2 #5723

Merged
merged 8 commits into from Feb 1, 2023
Merged

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Feb 1, 2023

Changelog

- Fix NodeInput selector not overflowing popup
- Removes OrderFilterItem mb-4
- Fix ProposalCard height with falsy status
- Fix question not collapsing
- Adds a decimal place to the proposal answers percentages where is needed
- Fix tooltip styling

Relevant Issues

closes #5663

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:enhancement Enhancement to existing feature type:feature Adding a new feature or functionality type:fix Fix for bug context:governance stardust Related to the Stardust Protocol labels Feb 1, 2023
@jeeanribeiro jeeanribeiro self-assigned this Feb 1, 2023
@jeeanribeiro jeeanribeiro changed the title Feat/governance polishing 2 feat|: governance polishing #2 Feb 1, 2023
@jeeanribeiro jeeanribeiro changed the title feat|: governance polishing #2 feat: governance polishing #2 Feb 1, 2023
@jeeanribeiro jeeanribeiro marked this pull request as ready for review February 1, 2023 13:45
@jeeanribeiro jeeanribeiro requested review from Tuditi and removed request for cvarley100 February 1, 2023 14:18
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 6a23d81 into develop Feb 1, 2023
@nicole-obrien nicole-obrien deleted the feat/governance-polishing-2 branch February 1, 2023 14:23
Tuditi pushed a commit that referenced this pull request Feb 1, 2023
* fix: NodeInput selector not overflowing popup

* fix: removes OrderFilterItem mb-4

* fix: ProposalCard height with falsy status

* fix: question not collapsing

* feat: add a decimal place to the proposal answers percentages where is needed

* fix: consistent tooltip styling
Tuditi pushed a commit that referenced this pull request Feb 1, 2023
* fix: NodeInput selector not overflowing popup

* fix: removes OrderFilterItem mb-4

* fix: ProposalCard height with falsy status

* fix: question not collapsing

* feat: add a decimal place to the proposal answers percentages where is needed

* fix: consistent tooltip styling
Tuditi added a commit that referenced this pull request Feb 1, 2023
* New Crowdin translations by Github Action

* feat: deep link opens already registered proposal (#5701)

* feat: deep link opens already registered proposal

* fixes from review

* try to prevent edge cases

* fixes after merge

* fix code convention import order

* update import

* fix: getProposalFromEventId

* format fixes

* fix tests failing

* fix: importing coding conventions

* change importing order in createProposalFromEvent

* fix relative imports

* fix: moves condition of selectedProposalId to only wrap the set store line

* fix: remove global flag from proposal ID regexp

---------

Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: undefined param get percentages (#5719)

* fix: undefined param get percentages

* fix: setWinnerAnswerIndex undefined answerStatuses

* fix: revert breaking change in i18n (#5720)

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

* feat-mobile: balance breakdown (#5689)

* feat: kickoff account actions drawer

* fix: features

* feat: add customize account

* feat: toggle account visibility

* feat: delete account

* feat: balance breakdown

* feat: finalize output consolidation

---------

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* fix: require at least one answer (#5718)

* fix: adjust logic to automatically abstain

* fix: PR fixes

---------

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>

* feat: governance polishing #2 (#5723)

* fix: NodeInput selector not overflowing popup

* fix: removes OrderFilterItem mb-4

* fix: ProposalCard height with falsy status

* fix: question not collapsing

* feat: add a decimal place to the proposal answers percentages where is needed

* fix: consistent tooltip styling

* fix: do not freeze on negative participation range (#5733)

* fix: do not freeze on negative participation range

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>

* refactor: move logic into separate function

---------

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* fix: add pending activity for voting (#5721)

* fix: add pending activity on voting

* chore: use correct error handling

* fix: update participation overview when vote is included

* refactor: simplify processAndAddToActivities

* chore: update locales

---------

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* fix: reset Governance dashboard on wallet switch (#5737)

* fix: add account switching for proposal details view

* chore: rename some components

* fix: allow switching on dashboard view

* chore: add explanatory comments

* chore: apply changes per PR review

* fix: fix details view if account with proposal gets deleted (#5739)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature type:feature Adding a new feature or functionality type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Additional Governance UI/UX polish #2
3 participants