Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unlock stronghold at the end of the onboarding process #7047

Merged
merged 7 commits into from
Jun 28, 2023
Merged

fix: unlock stronghold at the end of the onboarding process #7047

merged 7 commits into from
Jun 28, 2023

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jun 27, 2023 •
edited
Loading

Closes #4823

Summary

Unlock stronghold at the end of the onboarding process to avoid an error due to the stronghold file being locked for a long time

Changelog

- If the restore type is `stronghold`, unlock the stronghold file setting password at the end of the onboarding process

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

  • Create a profile and save a stronghold backup
  • Create a new profile
  • Testnet network
  • Restore an existing Tesnet profile
  • Use Stronghold backup
  • Select the stronghold file and set the password
  • Wait 2 minutes at the next 3 views
  • Finish the restore process without errors

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review June 27, 2023 11:43
begonaalvarezd
begonaalvarezd requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments 🙏🏼

packages/desktop/views/onboarding/views/complete-onboarding/views/EnterNameView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/complete-onboarding/views/EnterPinView.svelte Outdated Show resolved Hide resolved
...ges/desktop/views/onboarding/views/restore-from-stronghold/views/UnlockStrongholdView.svelte Outdated Show resolved Hide resolved
packages/shared/lib/contexts/onboarding/interfaces/onboarding-profile.interface.ts Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, added some comments 🙏🏼

packages/desktop/views/onboarding/views/complete-onboarding/CompleteOnboardingRouterView.svelte Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, added minor comments 🙏🏼

packages/desktop/views/onboarding/views/complete-onboarding/views/FinishOnboardingView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/complete-onboarding/views/FinishOnboardingView.svelte Outdated Show resolved Hide resolved
@begonaalvarezd
Copy link
Member

@cpl121 lets also update the PR title and description 🙏🏼

@cpl121 cpl121 changed the title fix: block onboarding process if stronghold is locked fix: unlock stronghold at the end of the onboarding process Jun 28, 2023
begonaalvarezd
begonaalvarezd approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@begonaalvarezd begonaalvarezd merged commit 61d9858 into develop Jun 28, 2023
@begonaalvarezd begonaalvarezd deleted the fix/restore-stronghold-lock-issue branch June 28, 2023 12:55
@Tuditi Tuditi mentioned this pull request Jun 28, 2023
Closed
3 tasks
msarcev pushed a commit that referenced this pull request Jul 4, 2023
@cpl121 @begonaalvarezd @msarcev
fix: unlock stronghold at the end of the onboarding process (#7047)
852f985 
* fix: block onboarding process if stronghold is locked

* fix: move logic to the router and check stronghold locked by bindings

* fix: move logic to finish onboarding view

* perf: simplify and rename unlockStronghold

* enhancement: simplify code & add comment

* chore: cleanup warnings

---------

Co-authored-by: Begoña Alvarez <balvarez@boxfish.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Impossible to restore Stronghold if it gets locked.
2 participants
@cpl121 @begonaalvarezd