Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash accounts if not selected output #8204

Merged
merged 5 commits into from
Mar 19, 2024
Merged

fix: crash accounts if not selected output #8204

merged 5 commits into from
Mar 19, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 15, 2024 •
edited
Loading

Closes #8205

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 requested a review from marc2332 March 15, 2024 10:29
@cpl121 cpl121 marked this pull request as ready for review March 15, 2024 10:29
@cpl121 cpl121 changed the title fix: crash-accounts-if-not-selected-output fix: crash accounts if not selected output Mar 15, 2024
@cpl121 cpl121 linked an issue Mar 15, 2024 that may be closed by this pull request
[Task]: fix crash error when account management view is without account information #8205
Closed
marc2332
marc2332 requested changes Mar 15, 2024
View reviewed changes
packages/shared/locales/en.json Outdated Show resolved Hide resolved
@cpl121 cpl121 requested a review from marc2332 March 15, 2024 13:12
@cpl121 cpl121 requested a review from evavirseda March 18, 2024 11:30
evavirseda
evavirseda requested changes Mar 18, 2024
View reviewed changes
packages/shared/locales/en.json Outdated
@@ -715,7 +715,8 @@
"unsetAsPrimary": "Unset as primary"
}
},
"notification": "Activate one account to access the dashboard."
"notification": "Activate one account to access the dashboard.",
"emptyAccounts": "There is no account to show, activate one first."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"emptyAccounts": "There is no account to show, activate one first."
"emptyAccounts": "There are no accounts to show, activate one first."

@cpl121 cpl121 requested a review from evavirseda March 18, 2024 16:26
@begonaalvarezd begonaalvarezd merged commit 0db5de7 into develop-iota2.0 Mar 19, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/crash-accounts-if-not-selected-output branch March 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@evavirseda evavirseda Awaiting requested review from evavirseda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: fix crash error when account management view is without account information
4 participants
@cpl121 @begonaalvarezd @marc2332 @evavirseda