Removes synchronous event handlers between peer manager to gossip service #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow the
p2p.Managerto continue execution without blocking ongossip.Servicechannels being free, the glue code (the event handlers) forp2p.Managertogossip.Serviceare now submitted to a worker pool which is instantiated by thegossip.Service.Before there was a chance that the event handlers would get stuck sending into the
gossip.Servicechannels, as thegossip.Serviceitself was sending into ap2p.Managerchannel, thus deadlocking both components. The intention was to circumvent this by having buffered channels but given the capacity of 10, this situation could still occur.