Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file extension to links #1118

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Add file extension to links #1118

merged 2 commits into from
Feb 14, 2023

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Feb 13, 2023

Description of change

Add file extension to (hopefully) all links to fix issues with links not being resolved as can be seen in the chapter links here.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested by @Dr-Electron here.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Dr-Electron
Copy link
Contributor

Seems to have fixed it. You can check it here:
https://iota-wiki-it-iota-iota1.vercel.app/shimmer/identity.rs/introduction/

@eike-hass eike-hass added the No changelog Excludes PR from becoming part of any changelog label Feb 13, 2023
@eike-hass eike-hass changed the title WIP: Add file extension to links Add file extension to links Feb 13, 2023
@eike-hass
Copy link
Collaborator Author

Blocked by an unrelated error:
error[E0599]: no method named with_burning_allowedfound for structClientBlockBuilder in the current scope

@eike-hass
Copy link
Collaborator Author

Merging despite the unrelated build failure to get the changes in the Wiki ASAP.

@eike-hass eike-hass merged commit cf49d77 into main Feb 14, 2023
@eike-hass eike-hass deleted the chore/fix-doc-links-md branch February 14, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants