-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrappers for JWT and JWS #1160
Merged
abdulmth
merged 10 commits into
feat/jwk-storage-document-ext-2
from
feat/jwt-jws-wrappers
May 10, 2023
Merged
Add wrappers for JWT and JWS #1160
abdulmth
merged 10 commits into
feat/jwk-storage-document-ext-2
from
feat/jwt-jws-wrappers
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
No changelog
Excludes PR from becoming part of any changelog
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Chore
Tedious, typically non-functional change
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
May 8, 2023
PhilippGackstatter
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
identity_credential/src/validator/vc_jwt_validation/credential_jwt_validator.rs
Outdated
Show resolved
Hide resolved
identity_credential/src/validator/vc_jwt_validation/decoded_jwt_credential.rs
Show resolved
Hide resolved
PhilippGackstatter
added a commit
that referenced
this pull request
May 12, 2023
* take changes from branch `jwk-storage-document-ext` * minor comments * add constructor for `WasmJwtCredentialValidationOptions` * minor fixes * Fix RevocationBitmap typo * Return `CredentialToken<T>` where possible * Improve error messages * Improve method name * Improve error messages, remove resolved TODOs * Wasm cleanup * Remove the removed `JwkStorage.public` method * Fix clippy lints * Test some cases for credential validation * Update `b64` docs in WasmJwsSignatureOptions * Add nonce verification during credential verif. * Add `b64=false` and `detached=true` test * Remove user-facing `crit` JOSE parameter * Add test setup and organize tests * Add wrappers for JWT and JWS (#1160) * Add more credential validator tests * Add custom error for external extensibility * Make source in custom error optional * Regenerate api-reference, remove crits * Add missing license header * Fix const/static clippy lint * Elide lifetimes; fix documented type * fix output handling * Add `std_rng` feature on `rand` * Fix `--features credential` dead code * make rustup failable * Update expected error in delete_did example --------- Co-authored-by: Philipp Gackstatter <philipp.gackstatter@iota.org> Co-authored-by: Eike Haß <eike-hass@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Chore
Tedious, typically non-functional change
No changelog
Excludes PR from becoming part of any changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Introduce wrappers around JWT and JWS tokens, also rename
CredentialToken
toDecodedJwtCredential
andToken
toDecodedJws
in WASM.