Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resolution example to use the new Resolver (#838) #840

Merged
merged 1 commit into from
May 6, 2022
Merged

Update resolution example to use the new Resolver (#838) #840

merged 1 commit into from
May 6, 2022

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented May 5, 2022 •
edited
Loading

Description of change

Merge #838 into dev.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass
Update resolution example to use the new Resolver (#838)
db4cf31 
Updates the resolution example to use the new Resolver.
@eike-hass eike-hass added the Documentation Improvements or additions to documentation. Excludes from changelog label May 5, 2022
olivereanderson
olivereanderson approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eike-hass eike-hass merged commit 17c6208 into dev May 6, 2022
@eike-hass eike-hass deleted the chore/merge-update-resolution-example branch May 6, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivereanderson olivereanderson olivereanderson approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation. Excludes from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eike-hass @olivereanderson