This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Add test vectors to demonstrate kerlissions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we only have one "expected" value (because of collisions in Kerl), we can simplify our definition.
|
It's been nearly tow years. Can you please review and merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the last trit to
0--instead of some deterministic padding scheme (e.g. ISO/IEC 7816-4)--means there are three possible inputs that produce the same hash output.This is technically a collision in Kerl (but not a collision in Keccak-384), but since it's unique to Iota and a direct consequence of a design decision (and therefore expected), and collisions are a (rather fun) type of vulnerability in cryptographic hash functions, I opted to coin the term "kerlission" instead.
This pull request adds test cases so that anyone auditing your code knows that kerlissions are totally expected.
Full write-up: Kerlissions in IOTA's Kerl hash function