Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Runner API to allow for external procedures #499

Closed
wants to merge 2 commits into from
Closed

Expose the Runner API to allow for external procedures #499

wants to merge 2 commits into from

Conversation

tensor-programming
Copy link
Contributor

@tensor-programming tensor-programming commented Feb 28, 2024

Description of change

The main change here is just to expose the Runner API and also update the libsodium-sys library to the libsodium-sys-stable version which is being properly maintained (the older version was achieved months ago). Exposing the Runner API makes it easier for anyone to create their own procedures without having to make a PR to the stronghold repository. This doesn't change the security of the library as anyone is able to create their own stronghold client even without these changes. All this change does, is make it possible for a 3rd party to write their own extension procedures in a way that works with the existing APIs. The security of these procedures is up to the author rather than the IF.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change is very simple, nothing to really test apart from the original tests in the system. Even without exposing the runner, anyone can build their own stronghold client with the current API.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tensor-programming tensor-programming closed this by deleting the head repository Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant